Migrate from prettier to oxfmt#5986
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5986 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 328 328
Lines 34255 34255
Branches 9574 9572 -2
=======================================
Hits 28713 28713
Misses 5114 5114
Partials 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi there—have you tried biome.js? I've been using it in my projects, and I think it's actually pretty good. |
fatadel
approved these changes
May 4, 2026
fatadel
left a comment
fatadel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking care of this! I've added just one nit (comment update), otherwise lgtm 👍🏻
canova
reviewed
May 5, 2026
canova
reviewed
May 5, 2026
| // Prettier config must be placed here to disable formatting rules from the | ||
| // base configs above, while allowing our custom rules below to take | ||
| // precedence. | ||
| prettierConfig, |
Member
There was a problem hiding this comment.
eslint-config-prettier essentially disables a bunch of formatting rules that might clash with the prettier formatting. I wonder if we need something for oxfmt too, but I think it's fine if it didn't clash already after the migration.
Numbers from my machine: `yarn prettier-fix` before: 6.5 seconds `yarn fmt` after: 1.3 seconds `yarn lint-fix` is still slow (9 seconds), I think that's bottlenecked on eslint.
Contributor
Author
I haven't tried it, I have no opinion on which to prefer. In any case, it's not hard to switch. |
Merged
canova
added a commit
that referenced
this pull request
May 26, 2026
Changes: [fatadel] Remove unused dependencies from package.json (#6010) [Nazım Can Altınova] Make profiler-cli work in sandboxed environments (#6003) [Markus Stange] Make profiler-edit run profile compacting before writing out the file (#6015) [Markus Stange] Migrate from prettier to oxfmt (#5986) [Markus Stange] Add a --symbolicate-wasm arg to profiler-edit. (#6008) [Markus Stange] Build and upload the cli artifact in PRs (#6020) [Markus Stange] Use @streamparser/json if the input is too large to fit in a V8 string (#6016) [Nazım Can Altınova] Print also the status output right after cli `load` command (#6019) [Nicolas Chevobbe] Update devtools-reps to 0.27.7 (#6030) [Nazım Can Altınova] Include `--search` option in `pq filter push` (#6026) [Nazım Can Altınova] Update all Yarn dependencies (2026-05-20) (#6033) [fatadel] Translate URL track-index state through profile sanitization (#6000) [Markus Stange] Make withSize use a wrapper element so that it can stop calling findDOMNode (#5988) [Markus Stange] Fix dhat importer (#6036) [Nazım Can Altınova] Annotate inlined frames in CLI call trees and stacks (#6041) [Nazım Can Altınova] Use proper types in cli tests instead of custom inline types (#6038) [Nazım Can Altınova] Fix text truncation for frames named after Object.prototype methods (#6044) [Nazım Can Altınova] Add missing key props to CodeErrorOverlay error list items (#6047) [depfu[bot]] ⬆️ Update oxfmt to version 0.51.0 (#6054) [Nazım Can Altınova] 🔃 Sync: l10n -> main (May 26, 2026) (#6058) [Nazım Can Altınova] Use URL-state symbol server for `profiler-cli function annotate` (#6051) [Nazım Can Altınova] Bump profiler-cli version to 0.2.0 (#6059) And special thanks to our localizers: fr: YD sr: Марко Костић (Marko Kostić) tr: Ali Demirtaş zh-CN: Olvcpr423 zh-CN: wxie
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numbers from my machine:
yarn prettier-fixbefore: 6.5 secondsyarn fmtafter: 1.3 secondsyarn lint-fixis still slow (9 seconds), I think that's bottlenecked on eslint.